phase-7_alpha: legacy code cleanup

server/services/BenchmarkProvider.ts

@@ -25,12 +25,13 @@ export class BenchmarkProvider {
   private static pe(summary: any): number | null {
     return summary?.summaryDetail?.trailingPE ?? summary?.defaultKeyStatistics?.forwardPE ?? null;
   }
-  private client: YahooFinanceClient;
   private cache: { data: MarketContext | null; expiresAt: number };
   private logger: Logger;
 
-  constructor({ logger }: BenchmarkProviderOptions = {}) {
-    this.client = new YahooFinanceClient();
+  constructor(
+    private readonly client: YahooFinanceClient,
+    { logger }: BenchmarkProviderOptions = {},
+  ) {
     this.cache = { data: null, expiresAt: 0 };
     this.logger = logger ?? (console as unknown as Logger);
   }