phase-1: optimize code

2026-06-04 01:32:05 -04:00
parent cd74497de6
commit 3513024fc6
58 changed files with 7380 additions and 850 deletions
@@ -47,3 +47,46 @@ test('_cryptoAdvice: >100% gain → Consider taking profits', () => {
  const { action } = advisor._cryptoAdvice({ costBasis: 10000, shares: 1 }, 25000);
  assert.equal(action, '🟠 Consider taking profits');
 });
+
+// ── Result map dot-notation normalisation (BRK.B / BRK-B) ───────────────────
+
+test('advise: BRK-B screener result matches BRK.B holding', async () => {
+  const mockResult = {
+    asset: { ticker: 'BRK-B', currentPrice: 500 },
+    signal: SIGNAL.STRONG_BUY,
+    inflated: { label: '🟢 BUY (High Conviction)' },
+    fundamental: { label: '🟢 BUY (High Conviction)' },
+  };
+  const screenedResults = { STOCK: [mockResult], ETF: [], BOND: [] };
+  const holding = {
+    ticker: 'BRK.B',
+    shares: 1,
+    costBasis: 400,
+    type: 'stock',
+    source: 'Robinhood',
+  };
+
+  const advice = await advisor.advise([holding], screenedResults);
+  // Should match and return a real signal, not "Not screened"
+  assert.equal(advice[0].signal, SIGNAL.STRONG_BUY);
+});
+
+test('advise: BRK.B screener result matches BRK-B holding', async () => {
+  const mockResult = {
+    asset: { ticker: 'BRK.B', currentPrice: 500 },
+    signal: SIGNAL.STRONG_BUY,
+    inflated: { label: '🟢 BUY (High Conviction)' },
+    fundamental: { label: '🟢 BUY (High Conviction)' },
+  };
+  const screenedResults = { STOCK: [mockResult], ETF: [], BOND: [] };
+  const holding = {
+    ticker: 'BRK-B',
+    shares: 1,
+    costBasis: 400,
+    type: 'stock',
+    source: 'Robinhood',
+  };
+
+  const advice = await advisor.advise([holding], screenedResults);
+  assert.equal(advice[0].signal, SIGNAL.STRONG_BUY);
+});